fix(parse): offset parsing when seconds are decimal #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
approved these changes
Sep 6, 2023
Tieske
force-pushed
the
waynec86/fix-date-offset-with-decimal-seconds
branch
from
5abbd0f to
8566b5f
Compare
Tieske
changed the title
Owner
|
@waynec86 thx for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This addresses #32
as well as adds test cases for when seconds of a timestamp are represented as a decimal, the offset +/-HH:MM is not respected for the timezone offset
Test Plan
Added 3 more tests and verified no other tests break